This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
Port reset function from master branch #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencefr
reviewed
Dec 20, 2017
| @@ -3,7 +3,8 @@ _build | |||
| **/CMakeFiles | |||
| **/CMakeCache.txt | |||
| *.pyc | |||
| sdk/ | |||
| **/build | |||
| /sdk/ | |||
There was a problem hiding this comment.
I'm not sure how git behaves, but is the absolute path here relative to the git repo?
There was a problem hiding this comment.
This is for ignoring the sdk folder in root but not ignoring the sdk folder in src/sdk @bencefr
There was a problem hiding this comment.
From the gitignore doc: A leading slash matches the beginning of the pathname. For example, "/.c" matches "cat-file.c" but not "mozilla-sha1/sha1.c".*
bencefr
approved these changes
Dec 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset function was first implemented in master branch. Porting it over to have it available also for pc-ble-driver v2.x versions.